Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable memory checking on dist'd builds #15

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

rkennedy-mode
Copy link

@rkennedy-mode rkennedy-mode commented Sep 7, 2021

Gets rid of the following message (as well as any performance penalties we may be paying):

WARN: Strict java memory checking is enabled, don't do release builds or performance runs with this enabled. Invoke "ant clean" and "ant -Djmemcheck=NO_MEMCHECK" to disable.

I've confirmed this by running the prior release locally:

% docker run -it --rm ghcr.io/mode/voltdb/voltdb:8.4.11-8be892170dd5a44ac99bc17199459007a02f0fa0
Initializing VoltDB...

 _    __      ____  ____  ____
| |  / /___  / / /_/ __ \/ __ )
| | / / __ \/ / __/ / / / __  |
| |/ / /_/ / / /_/ /_/ / /_/ /
|___/\____/_/\__/_____/_____/

--------------------------------

Build: 8.4.11 This is not from a known repository Community Edition
Loaded node-specific settings from voltdbroot/config/path.properties
Connecting to VoltDB cluster as the leader...
Host id of this node is: 0
Starting a new database cluster
WARN: User authentication is not enabled. The database is accessible and could be modified or shut down by anyone on the network.
Initializing the database. This may take a moment...
WARN: Strict java memory checking is enabled, don't do release builds or performance runs with this enabled. Invoke "ant clean" and "ant -Djmemcheck=NO_MEMCHECK" to disable.
WARN: This is not a highly available cluster. K-Safety is set to 0.
WARN: Durability is turned off. Command logging is off.
Server Operational State is: NORMAL
Server completed initialization.

We can see the warning regarding memory checking above. Then running the newly built release:

% docker run -it --rm ghcr.io/mode/voltdb/voltdb:8.4.11-29708815499c03ac6b67e6de0ac7eb01afbd2c51
Initializing VoltDB...

 _    __      ____  ____  ____
| |  / /___  / / /_/ __ \/ __ )
| | / / __ \/ / __/ / / / __  |
| |/ / /_/ / / /_/ /_/ / /_/ /
|___/\____/_/\__/_____/_____/

--------------------------------

Build: 8.4.11 This is not from a known repository Community Edition
Loaded node-specific settings from voltdbroot/config/path.properties
Connecting to VoltDB cluster as the leader...
Host id of this node is: 0
Starting a new database cluster
WARN: User authentication is not enabled. The database is accessible and could be modified or shut down by anyone on the network.
Initializing the database. This may take a moment...
WARN: This is not a highly available cluster. K-Safety is set to 0.
WARN: Durability is turned off. Command logging is off.
Server Operational State is: NORMAL
Server completed initialization.

We see that there is no longer a memory checking warning.

Hopefully gets rid of the following message (as well as any performance penalties we may be paying):

> WARN: Strict java memory checking is enabled, don't do release builds or performance runs with this enabled. Invoke "ant clean" and "ant -Djmemcheck=NO_MEMCHECK" to disable.
Without this the Docker image build hangs indefinitely, waiting for someone to answer the question:

> Do you want to continue? [Y/n]
@rkennedy-mode rkennedy-mode marked this pull request as ready for review September 8, 2021 17:06
Copy link

@ultrabluewolf ultrabluewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkennedy-mode rkennedy-mode merged commit a2d28ae into mode-release-8.4.x Sep 8, 2021
@rkennedy-mode rkennedy-mode deleted the disable-memcheck branch September 8, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants