Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The copyright check doesn't seem to be working #3141

Closed
celinval opened this issue Apr 15, 2024 · 0 comments · Fixed by #3170
Closed

The copyright check doesn't seem to be working #3141

celinval opened this issue Apr 15, 2024 · 0 comments · Fixed by #3170
Assignees
@jaisnan
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected. [I] CI / Infrastructure Work done to CI, tests and infrastructure.

Comments

@celinval
Copy link
Contributor

For example, #3134 (this commit) added a test without copyright statement, but CI passed.
@celinval celinval added [C] Internal Tracks some internal work. I.e.: Users should not be affected. [I] CI / Infrastructure Work done to CI, tests and infrastructure. labels Apr 15, 2024
@jaisnan jaisnan self-assigned this Apr 22, 2024
@adpaco-aws adpaco-aws mentioned this issue May 3, 2024
Merged
adpaco-aws added a commit that referenced this issue May 3, 2024
@adpaco-aws
Fix copyright check for expected tests (#3170)
36f715c 
This PR modifies the pattern used to exclude files from the copyright
check for `expected` files. This ensures we check the copyright in files
under `tests/expected/` while it skips the check for `expected` and
`*.expected` files. It also adds/modifies copyright headers for some
files that weren't being checked until now.

Resolves #3141
zpzigi754 pushed a commit to zpzigi754/kani that referenced this issue May 8, 2024
@adpaco-aws @zpzigi754
Fix copyright check for expected tests (model-checking#3170)
ae14b49 
This PR modifies the pattern used to exclude files from the copyright
check for `expected` files. This ensures we check the copyright in files
under `tests/expected/` while it skips the check for `expected` and
`*.expected` files. It also adds/modifies copyright headers for some
files that weren't being checked until now.

Resolves model-checking#3141
qinheping pushed a commit to qinheping/kani that referenced this issue May 9, 2024
@adpaco-aws @qinheping
Fix copyright check for expected tests (model-checking#3170)
7bc0cb8 
This PR modifies the pattern used to exclude files from the copyright
check for `expected` files. This ensures we check the copyright in files
under `tests/expected/` while it skips the check for `expected` and
`*.expected` files. It also adds/modifies copyright headers for some
files that weren't being checked until now.

Resolves model-checking#3141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaisnan jaisnan

Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected. [I] CI / Infrastructure Work done to CI, tests and infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix copyright check for expected tests adpaco-aws/rmc
2 participants
@celinval @jaisnan