Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CBMC version #2623

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Bump CBMC version #2623

merged 2 commits into from
Jul 25, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

Upgrade to CBMC 5.88.1

Resolved issues:

Resolves #ISSUE-NUMBER

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Existing regressions

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner July 25, 2023 14:25
jaisnan
jaisnan approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make the version changes to regression as well?

@zhassan-aws
Copy link
Contributor Author

The regression script only supports checking the major version (5) and the minor (88).

@zhassan-aws zhassan-aws added the Z-BenchCI Tag a PR to run benchmark CI label Jul 25, 2023
@zhassan-aws zhassan-aws added Z-BenchCI Tag a PR to run benchmark CI and removed Z-BenchCI Tag a PR to run benchmark CI labels Jul 25, 2023
@zhassan-aws zhassan-aws merged commit dfe1e95 into model-checking:main Jul 25, 2023
13 checks passed
@zhassan-aws zhassan-aws deleted the cbmc-5.88.1 branch July 25, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaisnan jaisnan jaisnan approved these changes

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhassan-aws @jaisnan