Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-upload macOS ARM binaries to draft release #3320

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

tautschnig
Copy link
Member

In #3266 a job to build macOS ARM binaries was added, but the artifacts weren't yet propagated to the release. This PR adds this missing step.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

In model-checking#3266 a job to build macOS ARM binaries was added, but the artifacts
weren't yet propagated to the release. This PR adds this missing step.
@tautschnig tautschnig requested a review from a team as a code owner July 3, 2024 19:23
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you. Is there any way of testing that this works?

@tautschnig
Copy link
Member Author

Looks we are also caught by actions/checkout#1809

@tautschnig
Copy link
Member Author

Great catch, thank you. Is there any way of testing that this works?

Not an easy one that I know of, I'm afraid.

@adpaco-aws
Copy link
Contributor

It's not easy to test but also not the end the of the world if it fails for any reason. In that case, one only needs to go the Release Bundle summary (e.g., this one for version 0.53.0), then download and attach the missing bundles to the release.

@celinval
Copy link
Contributor

celinval commented Jul 4, 2024

Wait, is there a reason why we are not running any test in the image like we do with the other images?

@tautschnig
Copy link
Member Author

Wait, is there a reason why we are not running any test in the image like we do with the other images?

We could certainly add such tests, but that wouldn't in itself test that the release auto-upload works.

@celinval
Copy link
Contributor

celinval commented Jul 5, 2024

No, but it would test the image which I think is more important.

@adpaco-aws
Copy link
Contributor

Thanks @tautschnig for adding this! 😃

Wait, is there a reason why we are not running any test in the image like we do with the other images?

@celinval I've opened #3331 to keep track of that work. Please feel free to comment if I missed something.

@adpaco-aws adpaco-aws enabled auto-merge (squash) July 8, 2024 21:14
@adpaco-aws adpaco-aws merged commit 53b702d into model-checking:main Jul 8, 2024
25 checks passed
@tautschnig tautschnig deleted the macos-arm-release branch July 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants