Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabled hierarchical logs in the compiler #3449

Merged
merged 1 commit into from
Aug 22, 2024

Commits on Aug 17, 2024

  1. Re-enabled hierarchical logs in the compiler

    We reverted the hierarchical logs a while ago (model-checking#2581) due to an outdated
    depedency that has since been fixed.
    
    I think this makes the logs much more readable, by identing the logs
    given the scope. More than one scope makes the lines way too long, which
    I think it's harder to read.
    
    This is how the logs look without this change:
    
    ```
    2024-08-17T02:42:21.874979Z DEBUG CodegenFunction{name="kani::assert"}: kani_compiler::codegen_cprover_gotoc::utils::debug: handling kani::assert
    2024-08-17T02:42:21.875008Z DEBUG CodegenFunction{name="kani::assert"}: kani_compiler::codegen_cprover_gotoc::utils::debug: variables:
    2024-08-17T02:42:21.875026Z DEBUG CodegenFunction{name="kani::assert"}: kani_compiler::codegen_cprover_gotoc::utils::debug: let _0: Ty { id: 4, kind: RigidTy(Tuple([])) }
    
    ```
    
    This is how it looks after this change:
    
    ```
    ┐kani_compiler::codegen_cprover_gotoc::codegen::function::CodegenFunction name="kani::assert"
    ├─── DEBUG kani_compiler::codegen_cprover_gotoc::utils::debug handling kani::assert
    ├─── DEBUG kani_compiler::codegen_cprover_gotoc::utils::debug variables:
    ├─── DEBUG kani_compiler::codegen_cprover_gotoc::utils::debug let _0: Ty { id: 4, kind: RigidTy(Tuple([])) }
    ├─── DEBUG kani_compiler::codegen_cprover_gotoc::utils::debug let _1: Ty { id: 6, kind: RigidTy(Bool) }
    
    ```
    celinval committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    867d5de View commit details
    Browse the repository at this point in the history