Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fully-qualified --package arguments #3593

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Support fully-qualified --package arguments #3593

merged 5 commits into from
Oct 12, 2024

Commits on Oct 11, 2024

  1. Support fully-qualified --package arguments 

    We were previously matching the name of the package, which would limit
users if the name is ambiguous.

Instead, use `cargo pkgid` to validate the `--package` argument and to
retrieve the package id.
    @celinval
    celinval committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    23fc3de View commit details
    Browse the repository at this point in the history

  2. Use run_piped instead

    @celinval
    celinval committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1a15f0f View commit details
    Browse the repository at this point in the history

  3. Update test expectations to match new error msg

    @celinval
    celinval committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    32e3c0f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Zyad Hassan <[email protected]>
    @celinval @zhassan-aws
    celinval and zhassan-aws authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    c69f26a View commit details
    Browse the repository at this point in the history

  2. Fix test expectations

    @celinval
    celinval authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    e618e0d View commit details
    Browse the repository at this point in the history