Emit an error when proof_for_contract function is not found #3609
+46
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
I wonder if this should be done as part of kani::middle::check_reachable_items which is where we run our validations. The main advantage is that we emit all possible configuration errors.
I won't block this PR though since it's a clear improvement to the existing flow. Thanks!
That makes sense. I'll check if it's easy to do that. |
|
I moved the check to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Kani panics if the function specified in the
proof_for_contractattribute is not found (e.g. because the function is not reachable) (see #3467). This PR adds an error message pointing out the issue.Towards #3467
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.