-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance frictional translational models based on ExternalCombiTable1D #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobolar
added
enhancement
New feature or enhancement
L: Mechanics.Translational
Issue addresses Modelica.Mechanics.Translational
labels
Dec 18, 2020
tobolar
requested review from
MartinOtter,
christoff-buerger,
HansOlsson and
beutlich
December 18, 2020 14:44
beutlich
force-pushed
the
translFrictionByCombiTable
branch
from
December 19, 2020 09:29
8ce12cd
to
1711f29
Compare
beutlich
reviewed
Dec 21, 2020
MartinOtter
approved these changes
Jan 11, 2021
HansOlsson
reviewed
Jan 12, 2021
HansOlsson
reviewed
Jan 12, 2021
HansOlsson
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
beutlich
force-pushed
the
translFrictionByCombiTable
branch
from
January 14, 2021 22:05
9124e3f
to
f18bfb0
Compare
beutlich
added a commit
to beutlich/ModelicaStandardLibrary
that referenced
this pull request
Jan 15, 2021
beutlich
added a commit
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or enhancement
L: Mechanics.Translational
Issue addresses Modelica.Mechanics.Translational
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #3662
Close #3664