Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChopperBuckBoost to PowerConverters #3774

Merged
merged 5 commits into from
Mar 21, 2021
Merged

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Mar 13, 2021

I know that there are lots of power converter layouts and we're presenting only basic ones, but I realized that one important topology is missing: the bidirectional two-quadrant buck/boost converter.
It is widely used in automotive to couple batteries with different voltages as well as for battery management systems.
Furthermore, it is an important topology for teaching power electronics and its control, and its a nice example for testing performance.

@AHaumer AHaumer added enhancement New feature or enhancement L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters labels Mar 13, 2021
@AHaumer AHaumer added this to the MSL4.0.1 milestone Mar 13, 2021
@AHaumer AHaumer self-assigned this Mar 13, 2021
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the comparisonSignals.txt for example ChopperBuckBoost_DutyCycle. Thanks.

@beutlich beutlich modified the milestones: MSL4.0.1, MSL4.1.0 Mar 14, 2021
@AHaumer
Copy link
Contributor Author

AHaumer commented Mar 14, 2021

Please add the comparisonSignals.txt for example ChopperBuckBoost_DutyCycle. Thanks.

Sorry for missing this, done

@beutlich beutlich dismissed their stale review March 14, 2021 09:45

Resolved.

@AHaumer AHaumer requested a review from beutlich March 14, 2021 09:46
@beutlich beutlich removed their request for review March 15, 2021 06:34
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in power electronics, but the contribution looks good to me.

BTW, we are investigating some numerical issues with it using OMC, see #6422, but I guess that's a tool issue.

Interval=1e-05,
Tolerance=1e-06), Documentation(info="<html>
<p>
Buck/boost chopper example template including both voltage sources; control not included yet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "control not included yet"? Is it planned to be added to this model in the near future? Otherwise, I'd remove the "yet", which gives an impression of work-in-progress

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I plan to implement control, but I don't have enough time to include it in the near future.

Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a valuable addition.

@AHaumer AHaumer merged commit db93c03 into modelica:master Mar 21, 2021
@beutlich beutlich removed the request for review from christiankral March 21, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants