-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChopperBuckBoost to PowerConverters #3774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the comparisonSignals.txt for example ChopperBuckBoost_DutyCycle. Thanks.
Sorry for missing this, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert in power electronics, but the contribution looks good to me.
BTW, we are investigating some numerical issues with it using OMC, see #6422, but I guess that's a tool issue.
Interval=1e-05, | ||
Tolerance=1e-06), Documentation(info="<html> | ||
<p> | ||
Buck/boost chopper example template including both voltage sources; control not included yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "control not included yet"? Is it planned to be added to this model in the near future? Otherwise, I'd remove the "yet", which gives an impression of work-in-progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I plan to implement control, but I don't have enough time to include it in the near future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and a valuable addition.
I know that there are lots of power converter layouts and we're presenting only basic ones, but I realized that one important topology is missing: the bidirectional two-quadrant buck/boost converter.
It is widely used in automotive to couple batteries with different voltages as well as for battery management systems.
Furthermore, it is an important topology for teaching power electronics and its control, and its a nice example for testing performance.