MODELIX-949: media type versioning + branch meta data access #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odzhychko
reviewed
Jun 28, 2024
model-server/src/test/kotlin/org/modelix/model/server/ModelServerTestUtil.kt
Outdated
Show resolved
Hide resolved
languitar
force-pushed
the
feature/media-type-versioning
branch
2 times, most recently
from
dec8323
to
66e49ee
Compare
languitar
changed the title
languitar
force-pushed
the
feature/media-type-versioning
branch
from
66e49ee
to
49751fb
Compare
JVM coverage report
|
Test Results141 files 141 suites 10m 59s ⏱️ Results for commit 2abc6b0. ♻️ This comment has been updated with latest results. |
odzhychko
requested changes
Jul 2, 2024
model-server/src/test/kotlin/org/modelix/model/server/handlers/ModelReplicationServerTest.kt
Show resolved
Hide resolved
This adds a new media type for requesting branch metadata. The commit also prepares the openapi-generator templates to support media-type versioning by optionally being able to declare separate handler methods per media type. For registering types for JSON serialization, the model needs to be annotated with the intended media type via the x-modelix-media-type vendor extension.
languitar
force-pushed
the
feature/media-type-versioning
branch
from
49751fb
to
2abc6b0
Compare
odzhychko
approved these changes
Jul 2, 2024
|
🎉 This PR is included in version 8.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new media type for requesting branch metadata as the first test case to prepare for media-type versioning. To achieve this versioning the scheme, the PR modifies the openapi-generator templates so that one can optionally declare separate handler methods per media type(s) to generate in the API interface.
This PR also adds kotest-assertions and therefore closes MODELIX-795
To be verified by reviewers