Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add litellm wrapper #204

Merged
merged 24 commits into from
May 11, 2024
Merged

Conversation

garyzhang99
Copy link
Collaborator

@garyzhang99 garyzhang99 commented May 9, 2024

Description

Add litellm chat wrapper to support more models

Now only implement chats.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@garyzhang99 garyzhang99 self-assigned this May 9, 2024
@garyzhang99 garyzhang99 added enhancement New feature or request feature labels May 9, 2024
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see inline comments

src/agentscope/models/litellm_model.py Outdated Show resolved Hide resolved
src/agentscope/models/litellm_model.py Outdated Show resolved Hide resolved
@DavdGao DavdGao linked an issue May 11, 2024 that may be closed by this pull request
@DavdGao DavdGao mentioned this pull request May 11, 2024
4 tasks
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments

src/agentscope/service/service_toolkit.py Outdated Show resolved Hide resolved
src/agentscope/service/service_toolkit.py Outdated Show resolved Hide resolved
src/agentscope/models/litellm_model.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit 497f8b9 into modelscope:main May 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for litellm
3 participants