Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for vision models in OpenAI Chat API, e.g. gpt-4o, gpt-4-turbo, etc. #221

Merged
merged 9 commits into from
May 14, 2024
Merged

Add support for vision models in OpenAI Chat API, e.g. gpt-4o, gpt-4-turbo, etc. #221

merged 9 commits into from
May 14, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented May 14, 2024 •
edited
Loading

Description

  • Update format function to support vision model in OpenAIChatWrapper
  • Add new unit tests for vision model format
  • Update tutorial
  • A new conversation example for gpt-4o and other vision models

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao requested a review from qbc2016 May 14, 2024 06:36
@DavdGao DavdGao requested a review from zhijianma May 14, 2024 06:43
pan-x-c
pan-x-c reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qbc2016
qbc2016 reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DavdGao DavdGao merged commit 2854904 into modelscope:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbc2016 qbc2016 qbc2016 left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

@zhijianma zhijianma Awaiting requested review from zhijianma

Assignees
No one assigned
Labels
feature ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavdGao @qbc2016 @pan-x-c