-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DashScope API based multimodal service functions in AgentScope library #255
Add DashScope API based multimodal service functions in AgentScope library #255
Conversation
The title of this PR isn't quite accurate. |
Although it might be a bit of a hassle, please consider adding corresponding tests for the new added service functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
BTM, it may be not convenient for users to have to pass the same api_key every time they use dashscope_xx_to_xx. Is it possible for users to set up an api_key with export api_key=xxx instead? @DavdGao
…add_services/dashscope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need modify test accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces three new services to the service toolkit: dashscope_text_to_image, dashscope_image_to_text, and dashscope_text_to_audio.
also fix a small error in examples/conversation_with_customized_services