Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Fix the bug in loguru that cannot display special tags #266

Merged
merged 3 commits into from
May 29, 2024
Merged

[HOTFIX] Fix the bug in loguru that cannot display special tags #266

merged 3 commits into from
May 29, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented May 29, 2024 •
edited
Loading

Background

  • logger.chat cannot display special tags normally. (e.g. html labels and special tags begin with "<")

Reason

  • In current version, we use the color label in loguru to display message with colored names, which will be mixed with labels within name and content

What in this PR

  • We display the color by special tags in terminal, e.g. \033[90m
  • To avoid saving the special tags (\033[90m) in files, we call logger.log twice (Lines 131-132, 143-144). The first time we display message in terminal with special tags, the second time we save this messages into files without these special tags.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao
Copy link
Collaborator Author

DavdGao commented May 29, 2024 •
edited
Loading

@qbc2016 please check if the fix would affect the message display in studio.

This was linked to issues May 29, 2024
[Bug]: The special tag used in loguru limits the tags that developers can used in AgentScope #227
Closed
[Bug]: logging error when use XML tags #264
Closed
@DavdGao DavdGao added bug Something isn't working ready for review labels May 29, 2024
@DavdGao DavdGao linked an issue May 29, 2024 that may be closed by this pull request
[Bug]:这里的日志打印，当ai生成的文本格式出现问题的时候，logger.chat就会报错 #262
Closed
@DavdGao DavdGao requested a review from zhijianma May 29, 2024 03:14
pan-x-c
pan-x-c approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit b754920 into modelscope:main May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-x-c pan-x-c pan-x-c approved these changes

@qbc2016 qbc2016 Awaiting requested review from qbc2016

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

@zhijianma zhijianma Awaiting requested review from zhijianma

Assignees
No one assigned
Labels
bug Something isn't working ready for review
Projects
None yet
Milestone
No milestone
2 participants
@DavdGao @pan-x-c