Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Add bs4 in setup.py to digest searched web pages #274

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Jun 5, 2024

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@qbc2016 qbc2016 requested a review from pan-x-c June 5, 2024 09:36
@qbc2016 qbc2016 changed the title Add bs4 in setup.py to digest searched web pages [Hotfix] Add bs4 in setup.py to digest searched web pages Jun 5, 2024
Copy link
Collaborator

@garyzhang99 garyzhang99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyzhang99 garyzhang99 merged commit e12a24b into modelscope:main Jun 5, 2024
4 checks passed
@qbc2016 qbc2016 deleted the dev_bs4 branch August 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants