Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the typing of the agents' reply function and update their docstrings. #314

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Unify the typing of the agents' reply function and update their docstrings. #314

merged 2 commits into from
Jul 2, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Jun 24, 2024 •
edited
Loading

Description

  1. Unify the typing of the agents' reply function as follows to provide more clear and correct guidance in typing.
    def reply(self, x: Optional[Union[Msg, Sequence[Msg]]] = None) -> Msg:
  1. Update the docstrings of the reply function.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao added enhancement New feature or request ready for review labels Jun 24, 2024
xieyxclack
xieyxclack reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pan-x-c
pan-x-c approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit 401fe3a into modelscope:main Jul 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbc2016 qbc2016 qbc2016 left review comments

@xieyxclack xieyxclack xieyxclack left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

@FredericW FredericW Awaiting requested review from FredericW

@zhijianma zhijianma Awaiting requested review from zhijianma

@garyzhang99 garyzhang99 Awaiting requested review from garyzhang99

Assignees
No one assigned
Labels
enhancement New feature or request ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavdGao @qbc2016 @xieyxclack @pan-x-c