Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix gradio displaying user message twice #317

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ZiTao-Li
Copy link
Collaborator


name: Fix gradio displaying user message twice
about: bug-fixing

Description

The current as_gradio displays the user input message on the left hand side. To prevent this:

  • rename the disable_studio parameter of _chat to disable_gradio to avoid ambiguity;
  • set disable_gradio=True in UserAgent.speak .

Before fixing:
Screenshot 2024-06-26 at 1 47 00 PM

After fixing:
Screenshot 2024-06-26 at 1 46 08 PM

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@ZiTao-Li ZiTao-Li added bug Something isn't working ready for review labels Jun 26, 2024
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ZiTao-Li ZiTao-Li merged commit 05b8d54 into modelscope:main Jul 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants