Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If it is json(str) convert to json(dict) #334

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

samchaolau
Copy link
Contributor


name: Pull Request
about: Create a pull request

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

src/agentscope/service/service_toolkit.py Outdated Show resolved Hide resolved
@DavdGao
Copy link
Collaborator

DavdGao commented Jul 15, 2024

@samchaolau Please execute pre-commit to reformat the file, so that we can merge this PR as soon as possible.

pre-commit run --all-files

@DavdGao DavdGao merged commit 2baffcb into modelscope:main Jul 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants