Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host url option in Ollama model wrappers #365

Merged
merged 34 commits into from
Jul 26, 2024

Conversation

garyzhang99
Copy link
Collaborator

@garyzhang99 garyzhang99 commented Jul 25, 2024

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

wenhao and others added 30 commits February 22, 2024 14:51
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add host argument in the constructor fucntion of the OllamaChatWrapper class as well

@DavdGao DavdGao linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit 17aec27 into modelscope:main Jul 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agentscope Error loading ollama model
2 participants