Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs for flask #391

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix bugs for flask #391

merged 1 commit into from
Aug 7, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Aug 7, 2024

Description

  1. change keys from inputs to messages in flask services since the default messages_key has been changed to messages
  2. remove reform_dialogue in flask services since it has been done before calling post

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@qbc2016 qbc2016 requested a review from DavdGao August 7, 2024 12:23
DavdGao
DavdGao approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit ab46935 into modelscope:main Aug 7, 2024
13 checks passed
@qbc2016 qbc2016 deleted the dev_bugfix_flask branch August 7, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbc2016 @DavdGao