Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the repo by removing the deprecated modules and merging the files with the same functionalities. #422

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Clean the repo by removing the deprecated modules and merging the files with the same functionalities. #422

merged 5 commits into from
Aug 28, 2024

Conversation

DavdGao
Copy link
Collaborator

@DavdGao DavdGao commented Aug 27, 2024 •
edited
Loading

Description

  • Merge utils/common.py and utils/tools.py into utils/common.py
  • Prefix inner functions with "_"
  • Remove deprecated PromptEngine module, which is declared to be deprecated in v0.0.6.
  • Remove text-to-image agent, which is declared to be deprecated in v0.0.6.
  • Improve OpenAI services to avoid unnecessary imports.
  • Remove empty files test.py and file_manager.py in the root directory

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao mentioned this pull request Aug 27, 2024
Closed
@DavdGao DavdGao linked an issue Aug 27, 2024 that may be closed by this pull request
"AttributeError: can't set attribute..." #423
Closed
qbc2016
qbc2016 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DavdGao DavdGao merged commit 79bf906 into modelscope:main Aug 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhijianma zhijianma zhijianma left review comments

@qbc2016 qbc2016 qbc2016 approved these changes

@pan-x-c pan-x-c Awaiting requested review from pan-x-c

@garyzhang99 garyzhang99 Awaiting requested review from garyzhang99

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"AttributeError: can't set attribute..."
3 participants
@DavdGao @qbc2016 @zhijianma