Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready] Add API Call & Example OPs #463

Merged
merged 20 commits into from
Nov 7, 2024
Merged

[Ready] Add API Call & Example OPs #463

merged 20 commits into from
Nov 7, 2024

Conversation

drcege
Copy link
Collaborator

@drcege drcege commented Oct 24, 2024 •
edited
Loading

Summary of Changes

  • Added APIModel
    • Compatible with OpenAI and DashScope requests.
  • New Operations Utilizing API Calls
    • CalibrateQAMapper
    • CalibrateQueryMapper
    • CalibrateResponseMapper
  • Related Updates
    • Unit tests passed locally.
    • Added docs.

TODO

  • Implement API request retry (to be refined in a separate PR)

Note

Recommended to merge after #454, handle code conflicts carefully, and update the operator count correctly.

@drcege drcege requested a review from HYLcool October 29, 2024 03:50
@drcege drcege self-assigned this Oct 29, 2024
@drcege drcege added the enhancement New feature or request label Oct 29, 2024
@drcege drcege marked this pull request as ready for review October 29, 2024 06:45
@drcege drcege changed the title Add api calling & example OPs [Ready] Add API call & Example OPs Nov 1, 2024
@drcege drcege changed the title [Ready] Add API call & Example OPs [Ready] Add API Call & Example OPs Nov 1, 2024
@drcege drcege requested a review from pan-x-c November 1, 2024 03:43
BeachWang
BeachWang reviewed Nov 1, 2024
View reviewed changes
configs/config_all.yaml Outdated Show resolved Hide resolved
data_juicer/ops/mapper/calibrate_qa_mapper.py Show resolved Hide resolved
data_juicer/ops/mapper/calibrate_qa_mapper.py Outdated Show resolved Hide resolved
@drcege drcege requested a review from BeachWang November 5, 2024 02:04
BeachWang
BeachWang approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@BeachWang BeachWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drcege drcege merged commit fe2b4cf into main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeachWang BeachWang BeachWang approved these changes

@HYLcool HYLcool Awaiting requested review from HYLcool

@Cathy0908 Cathy0908 Awaiting requested review from Cathy0908

@zhijianma zhijianma Awaiting requested review from zhijianma

@garyzhang99 garyzhang99 Awaiting requested review from garyzhang99

@yxdyc yxdyc Awaiting requested review from yxdyc

@pan-x-c pan-x-c Awaiting requested review from pan-x-c

Assignees

@drcege drcege

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drcege @BeachWang