New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-runner-chrome] remove find installations workaround #281

Closed

LarsDenBakker opened this issue Jul 31, 2020 · 2 comments · Fixed by #1146

Labels

enhancement good first issue

Member

LarsDenBakker commented Jul 31, 2020 •

edited

Loading

We no longer need our workaround here: https://github.com/modernweb-dev/web/blob/master/packages/test-runner-chrome/src/findExecutablePath.ts, since it's fixed upstream: GoogleChrome/chrome-launcher#209

LarsDenBakker added enhancement good first issue labels

deebloo commented Aug 10, 2020

is the whole fineExecutablePath.ts file the workaround?

Member Author

LarsDenBakker commented Aug 10, 2020

This if statement is the workaround: https://github.com/modernweb-dev/web/blob/master/packages/test-runner-chrome/src/findExecutablePath.ts#L21

LarsDenBakker mentioned this issue

feat(test-runner-chrome): use fast chrome-launcher installation finder #1146

Merged

LarsDenBakker closed this as completed in #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment