Check default paths first when running on Mac #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested changes
Jun 25, 2020
|
@patrickhulce addressed comments |
|
@patrickhulce thanks for the feedback. I moved the logic into the Chrome finder. Looks much better now. |
patrickhulce
approved these changes
Jun 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the lsregister dump can take up to a couple seconds on MacOS. This patch ensures that we check for default paths first and only do the dump if the browser is not located in
/Applications/Google Chrome.appor/Applications/Google Chrome Canary.app.Note: I couldn't really test all execution paths for the new method as I am not able to stub the
fspackage entirely (as you could do it with jest for example).fixes: #207