Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

refactor: misc #9

Merged
merged 1 commit into from
Oct 22, 2022
Merged

refactor: misc #9

merged 1 commit into from
Oct 22, 2022

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Oct 21, 2022 •
edited
Loading

  • move inline install scripts to files
  • make steps cross-platform where possible
  • replace set-output mechanism (soon deprecated)
  • test both cmd and pwsh on Windows
  • save cache after install even if workflow fails
  • set env vars for HPC kit, FC and install location
  • fix Windows cache restore failure #7: don't use GNU tar on Windows (can't unpack symlinks)
  • add MSVC linker bindir to system path
  • workaround libimf.so missing issue on Linux
  • make install location configurable (support relative, absolute and ~-expanded paths)
  • warn about windows caveats in README
    • must use default install location
    • must use cmd or pwsh, not bash
    • may need to set micromamba bin dir path

@wpbonelli wpbonelli marked this pull request as ready for review October 22, 2022 03:04
@wpbonelli wpbonelli force-pushed the develop branch 3 times, most recently from b000995 to 9430643 Compare October 22, 2022 03:23
@wpbonelli
refactor: misc
eecb738 
* move inline install scripts back to files
* make steps cross-platform where possible
* replace set-output mechanism (soon deprecated)
* test compile on bash, cmd and pwsh on Windows
* save cache after install even if workflow fails
* set env vars for HPC kit, FC and install location
* add conventional commits to README and CONTRIBUTING
* fix cache restore issue on windows
* prepend MSVC linker bindir to system path
* don't use GNU tar on Windows (can't unpack symlinks)
* workaround libimf.so missing issue on Linux
* make install location configurable
* resolve relative paths and expand symlinks
@wpbonelli wpbonelli mentioned this pull request Oct 22, 2022
Closed
@wpbonelli wpbonelli merged commit ec92e8f into modflowpy:main Oct 22, 2022
@sanguinariojoe sanguinariojoe mentioned this pull request Oct 22, 2022
Closed
@wpbonelli wpbonelli deleted the develop branch October 22, 2022 15:17
@wpbonelli wpbonelli mentioned this pull request Oct 26, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows cache restore failure
1 participant
@wpbonelli