Skip to content

Commit

Permalink
FIX-#2667: Change names of files for development env (#2668)
Browse files Browse the repository at this point in the history
Signed-off-by: Alexey Prutskov <[email protected]>
  • Loading branch information
prutskov authored Feb 3, 2021
1 parent b0f92b8 commit e25a5e0
Show file tree
Hide file tree
Showing 10 changed files with 25 additions and 25 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -303,7 +303,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -357,7 +357,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: ${{matrix.python-version}}
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -420,7 +420,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -453,7 +453,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -486,7 +486,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: ${{matrix.python-version}}
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -566,7 +566,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: ${{matrix.python-version}}
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: 3.7
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: ${{matrix.python-version}}
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: ${{matrix.python-version}}
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down Expand Up @@ -288,7 +288,7 @@ jobs:
- uses: conda-incubator/setup-miniconda@v2
with:
activate-environment: modin
environment-file: environment.yml
environment-file: environment-dev.yml
python-version: ${{matrix.python-version}}
channel-priority: strict
use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
Expand Down
4 changes: 2 additions & 2 deletions ci/jenkins/build-tests/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM python:3.6.6-stretch

COPY requirements.txt requirements.txt
RUN pip install -r requirements.txt
COPY requirements-dev.txt requirements-dev.txt
RUN pip install -r requirements-dev.txt

COPY . .
RUN pip install -e .
Expand Down
4 changes: 2 additions & 2 deletions ci/jenkins/performance-tests/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM python:3.6.6-stretch

COPY requirements.txt requirements.txt
RUN pip install -r requirements.txt
COPY requirements-dev.txt requirements-dev.txt
RUN pip install -r requirements-dev.txt
RUN pip install -q pytest==3.9.3 awscli pytest-benchmark feather-format lxml openpyxl xlrd numpy matplotlib sqlalchemy

COPY . .
Expand Down
4 changes: 2 additions & 2 deletions ci/teamcity/Dockerfile.teamcity-ci
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
#
# tar cf ci/teamcity/modin.tar .
#
# docker build --build-arg ENVIRONMENT=environment.yml -t modin-project/teamcity-ci:${BUILD_NUMBER} -f ci/teamcity/Dockerfile.teamcity-ci ci/teamcity
# docker build --build-arg ENVIRONMENT=environment-dev.yml -t modin-project/teamcity-ci:${BUILD_NUMBER} -f ci/teamcity/Dockerfile.teamcity-ci ci/teamcity

FROM rayproject/ray:1.0.1

ARG ENVIRONMENT=environment.yml
ARG ENVIRONMENT=environment-dev.yml

ADD modin.tar /modin
ADD git-rev /modin/git-rev
Expand Down
2 changes: 1 addition & 1 deletion ci/teamcity/build-docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def execute_command(cmd):
"(cd ../.. && git archive -o ci/teamcity/modin.tar $(cat ci/teamcity/git-rev))"
)
base_image = "ray-project/deploy"
requirements = "requirements.txt"
requirements = "requirements-dev.txt"
execute_command(
"docker build -f Dockerfile.modin-base --build-arg BASE_IMAGE={} -t modin-project/modin-base .".format(
base_image
Expand Down
4 changes: 2 additions & 2 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ dependencies for running the tests and formatting the code:

.. code-block:: bash
conda env create --file environment.yml
conda env create --file environment-dev.yml
# or
pip install -r requirements.txt
pip install -r requirements-dev.txt
Code Formatting and Lint
------------------------
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/tutorial/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM continuumio/miniconda3

RUN conda install -c conda-forge psutil setproctitle
RUN pip install -r requirements.txt
RUN pip install -r requirements-dev.txt

File renamed without changes.

0 comments on commit e25a5e0

Please sign in to comment.