-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move groupby.agg logic into query compiler #1879
Labels
Code Quality 💯
Improvements or issues to improve quality of codebase
Comments
ienkovich
added
the
Regression ↩️
Something that used to work but doesn't anymore
label
Jul 31, 2020
I am going to label this slightly differently. The patch was never upstreamed. |
devin-petersohn
added
Code Quality 💯
Improvements or issues to improve quality of codebase
and removed
Regression ↩️
Something that used to work but doesn't anymore
labels
Jul 31, 2020
devin-petersohn
changed the title
[BUG] Defaulting to pandas on a simple groupby by a single column
Move groupby.agg logic into query compiler
Jul 31, 2020
devin-petersohn
added a commit
to devin-petersohn/modin
that referenced
this issue
Jul 31, 2020
…compiler Signed-off-by: Devin Petersohn <[email protected]>
6 tasks
devin-petersohn
added a commit
to devin-petersohn/modin
that referenced
this issue
Sep 1, 2020
…compiler Signed-off-by: Devin Petersohn <[email protected]>
YarShev
pushed a commit
that referenced
this issue
Sep 3, 2020
Signed-off-by: Devin Petersohn <[email protected]>
aregm
pushed a commit
to aregm/modin
that referenced
this issue
Sep 16, 2020
…compiler (modin-project#1885) Signed-off-by: Devin Petersohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System information
Test case:
In the execution log I see
Previously we could process such aggregates in OmniSci back-end, now it's defaulted to pandas in front-end. That 'breaks' OmniSci backend (processing doesn't happen in OmniSci). Don't know when degradation happened. Probably some code was moved from query compiler to front-end.
The text was updated successfully, but these errors were encountered: