-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-#2720: Add documentation for partition API #2721
Conversation
Signed-off-by: Igoshev, Yaroslav <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 83.00% 86.00% +3.00%
==========================================
Files 126 127 +1
Lines 13904 14191 +287
==========================================
+ Hits 11541 12205 +664
+ Misses 2363 1986 -377
Continue to review full report at Codecov.
|
d1ddb54
to
5ad49d1
Compare
Co-authored-by: Alexey Prutskov <[email protected]> Signed-off-by: Igoshev, Yaroslav <[email protected]>
5ad49d1
to
b860376
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restructure the document so that usage goes first and details go later.
Signed-off-by: Igoshev, Yaroslav <[email protected]>
@devin-petersohn , the document is restructured. |
Co-authored-by: Devin Petersohn <[email protected]> Signed-off-by: Igoshev, Yaroslav <[email protected]>
bd9d069
to
5223535
Compare
Signed-off-by: Igoshev, Yaroslav <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @YarShev! Can you build the documentation and post a screenshot for the page?
0381b03
to
bd19453
Compare
Co-authored-by: Devin Petersohn <[email protected]> Signed-off-by: Igoshev, Yaroslav <[email protected]>
bd19453
to
cfabb0d
Compare
@devin-petersohn , sure. But let's merge #2642 at first. |
Signed-off-by: Igoshev, Yaroslav <[email protected]>
@devin-petersohn , the doc page was updated in accordance with the changes in #2643 . |
The doc page is moved into #2643 . |
Closing the PR because the doc page was merged as a part of the #2643 . |
Signed-off-by: Igoshev, Yaroslav [email protected]
What do these changes do?
flake8 modin
black --check modin
git commit -s