Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5722: Use full axis function when casting to "category" #6222

Merged
merged 2 commits into from
Jun 1, 2023
Merged

FIX-#5722: Use full axis function when casting to "category" #6222

merged 2 commits into from
Jun 1, 2023

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented May 31, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: modin can't share categories between multiple frames when pandas can #5722
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev YarShev requested a review from a team as a code owner May 31, 2023 08:50
dchigarev
dchigarev previously approved these changes May 31, 2023
View reviewed changes
@YarShev
fix hdk
f622922 
Signed-off-by: Igoshev, Iaroslav <[email protected]>
@YarShev YarShev requested a review from a team as a code owner May 31, 2023 11:40
@dchigarev dchigarev mentioned this pull request May 31, 2023
Closed
@dchigarev dchigarev merged commit 930b8fb into modin-project:master Jun 1, 2023
@dchigarev dchigarev mentioned this pull request Jun 1, 2023
Merged
7 tasks
@YarShev YarShev deleted the dev/yigoshev-issue5722 branch November 2, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: modin can't share categories between multiple frames when pandas can
2 participants
@YarShev @dchigarev