Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#7315: Refactor axis checks in squeeze #7400

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

noloerino
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Avoid unnecessary length checks in df.squeeze #7315
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@noloerino noloerino changed the title PERF-#7315: Remove unnecessary length check in squeeze PERF-#7315: Refactor axis checks in squeeze Sep 20, 2024
@noloerino noloerino changed the title PERF-#7315: Refactor axis checks in squeeze REFACTOR-#7315: Refactor axis checks in squeeze Sep 20, 2024
@anmyachev
Copy link
Collaborator

@noloerino did you sign your commits with -s option?

@noloerino
Copy link
Collaborator Author

@noloerino did you sign your commits with -s option?

Just fixed.

@anmyachev anmyachev merged commit 8b8806e into modin-project:main Sep 20, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid unnecessary length checks in df.squeeze
2 participants