Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use True value for isnull field #120

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Use True value for isnull field #120

wants to merge 1 commit into from

Conversation

PeterTillema
Copy link

Fix #119

@coveralls
Copy link

Coverage Status

Coverage decreased (-95.9%) to 0.0% when pulling a76f308 on PeterTillema:patch-1 into 90a8ed5 on modlinltd:develop.

@asfaltboy
Copy link
Member

Could we add a failing test case that this change fixes?

@eriktelepovsky
Copy link

@PeterTillema your fix is not enough but thank you for pointing me. I created PR which solves the issue correctly: #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend bug needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is NULL should have value "True", not "None"
4 participants
@PeterTillema @coveralls @asfaltboy @eriktelepovsky