Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stm32] Watchdog IWDG driver #1009

Merged
merged 2 commits into from
May 5, 2023
Merged

[stm32] Watchdog IWDG driver #1009

merged 2 commits into from
May 5, 2023

Conversation

victorandrehc
Copy link
Contributor

This is a proposal to add basic iwdg support to modm.

@rleh rleh assigned rleh and unassigned rleh Apr 26, 2023
@rleh rleh self-requested a review April 26, 2023 07:56
rleh
rleh reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice driver, thanks!

I have some comments/suggestions below:

examples/nucleo_f072rb/independend_watchdog/main.cpp Show resolved Hide resolved
examples/nucleo_f072rb/independend_watchdog/project.xml Outdated Show resolved Hide resolved
src/modm/platform/iwdg/stm32/iwdg.cpp Show resolved Hide resolved
src/modm/platform/iwdg/stm32/iwdg.hpp Outdated Show resolved Hide resolved
src/modm/platform/iwdg/stm32/iwdg.hpp Outdated Show resolved Hide resolved
src/modm/platform/iwdg/stm32/iwdg.hpp Outdated Show resolved Hide resolved
src/modm/platform/iwdg/stm32/module.lb Outdated Show resolved Hide resolved
@rleh rleh added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Apr 27, 2023
@rleh rleh changed the title Feature/iwdg [stm32] Watchdog IWDG driver Apr 27, 2023
@rleh rleh added this to the 2023q2 milestone Apr 27, 2023
@chris-durand chris-durand self-requested a review April 27, 2023 23:15
@victorandrehc victorandrehc force-pushed the feature/iwdg branch 2 times, most recently from b1b96b6 to bcb2cf8 Compare May 4, 2023 11:23
rleh
rleh approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ❤️

@victorandrehc
Copy link
Contributor Author

@rleh I am not really getting why the macos test is failing.

@rleh
Copy link
Member

rleh commented May 4, 2023

There currently is an issue with the MacOS CI, has something to do with apple thinking it's a good idea to link g++ to their Clang/LLVM binary. Clang 14 seems to have some issues.

We can just ignore it for this pull request.

chris-durand
chris-durand approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

src/modm/platform/iwdg/stm32/iwdg.cpp Outdated Show resolved Hide resolved
src/modm/platform/iwdg/stm32/module.lb Outdated Show resolved Hide resolved
salkinium
salkinium approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Ideally squash it into two commits, one for the peripheral and one for the example. (I can do it too if it's annoying for you.)

rleh
rleh approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I squashed the commits and rebased, now the MacOS CI problem should pass.
Lets merge this pull request next :)

@rleh rleh added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels May 5, 2023
@rleh rleh merged commit d772940 into modm-io:develop May 5, 2023
@victorandrehc victorandrehc deleted the feature/iwdg branch February 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand approved these changes

@rleh rleh rleh approved these changes

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
feature 🚧
Milestone
2023q2
Development

Successfully merging this pull request may close these issues.
5 participants
@victorandrehc @rleh @salkinium @chris-durand @wald-zat