Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: include typescript module declaration #292

Merged
merged 2 commits into from
Mar 20, 2023
Merged

feature: include typescript module declaration #292

merged 2 commits into from
Mar 20, 2023

Conversation

to-codando
Copy link
Contributor

I'm working on a project where I've adopted Typescript as the "language".

I needed to include support for declaring types for a better development experience.

I believe it can be useful for other colleagues and that's why I make this suggestion.

If this is beneficial and brings real benefits, please approve the pull request.

I remain at your disposal if additional clarification is needed.

Thank you very much.

Copy link
Owner

@modosc modosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not a ts person but this seems fine.

one thing you will have to do is include types/* in the files property of package.json - otherwise the types won't actually ship on npm.

@to-codando
Copy link
Contributor Author

i'm not a ts person but this seems fine.

one thing you will have to do is include types/* in the files property of package.json - otherwise the types won't actually ship on npm.

Thank you for the tips.

If you have any other adjustments to make, please let me know.

I remain available. Thanks.

@modosc modosc merged commit e2682e1 into modosc:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants