-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features extending instance hooks #952
Comments
That's usually because those environment variables might not be supported yet or have a different name than the other launchers. |
I believe the hooks in the Modrinth App currently don't support any variables, they're basically just triggers for running commands. They probably can be made more powerful in the future |
It seems that this feature request is already in the TODO list in code: code/packages/app-lib/src/api/profile/mod.rs Lines 780 to 802 in 0f2ddb4
|
* Fix subscriptions edge case * prep
Is your suggested enhancement related to a problem? Please describe.
Modrinth doesn't give any documentation towards the hooks for instances. My test script fails with error code 2 with zero logging from within the Modrinth app itself, except for the toast telling me it failed with error code 2.
Describe the solution you'd like
Some documentation towards the hooks and environment variables (or command line args) provided by Modrinth for the instance to use. I have provided some example images from MultiMC for reference towards what I would like to be added to Modrinth.
Describe alternatives you've considered
I have attempted to create a script that tells me what environment variables and command line arguments are available, but fails with error code 2 with zero explanation from the Modrinth app. The script works perfectly fine outside of Modrinth, but refuses to run and exits with error code 2 when used as a hook.
Additional context
N/A, all screenshots and context have been included above.
The text was updated successfully, but these errors were encountered: