fix(rspack): only patchChunkSplit when config set exposes

module-federation · Oct 21, 2024 · 83c3f44 · 83c3f44
1 parent cf14509
commit 83c3f44
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/tricky-sheep-travel.md b/.changeset/tricky-sheep-travel.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/rspack': patch
+---
+
+fix(rspack): only patchChunkSplit when config set exposes
diff --git a/packages/rspack/src/ModuleFederationPlugin.ts b/packages/rspack/src/ModuleFederationPlugin.ts
@@ -67,7 +67,12 @@ export class ModuleFederationPlugin implements RspackPluginInstance {
     }
     this._checkSingleton(compiler);
     this._patchBundlerConfig(compiler);
-    this._patchChunkSplit(compiler, options.name);
+    const containerManager = new ContainerManager();
+    containerManager.init(options);
+
+    if (containerManager.enable) {
+      this._patchChunkSplit(compiler, options.name);
+    }
 
     options.implementation = options.implementation || RuntimeToolsPath;
     let disableManifest = options.manifest === false;
@@ -79,8 +84,6 @@ export class ModuleFederationPlugin implements RspackPluginInstance {
     }
     if (!disableManifest && options.exposes) {
       try {
-        const containerManager = new ContainerManager();
-        containerManager.init(options);
         options.exposes = containerManager.containerPluginExposesOptions;
       } catch (err) {
         if (err instanceof Error) {