fix(bridge-react): add default basename for WraperRouterProvider (#3020)

module-federation · Oct 8, 2024 · 8a77291 · 8a77291
1 parent 9bd1b12
commit 8a77291
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/cuddly-pumpkins-switch.md b/.changeset/cuddly-pumpkins-switch.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/bridge-react': patch
+---
+
+fix(bridge-react): add default basename for WraperRouterProvider
diff --git a/packages/bridge/bridge-react/src/router-v6.tsx b/packages/bridge/bridge-react/src/router-v6.tsx
@@ -60,7 +60,8 @@ function WraperRouterProvider(
     return <RouterProvider router={MemeoryRouterInstance} />;
   } else {
     const BrowserRouterInstance = createBrowserRouter(routers, {
-      basename: routerContextProps.basename,
+      // In host app, the routerContextProps is {}, so we should use router.basename as fallback
+      basename: routerContextProps.basename || router.basename,
       future: router.future,
       window: router.window,
     });