chore: use real dirName instead of urlDirName #2906
Conversation
🦋 Changeset detectedLatest commit: f5634c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This pull request updates the packages/sdk/src/node.ts file to use the actual __dirname value instead of the urlDirName variable when executing the script node. This change ensures that the correct directory path is used for resolving any relative imports or file references within the script, improving the overall integration with the existing codebase.
File Summaries
| File | Summary |
|---|---|
| packages/sdk/src/node.ts | The code changes replace the use of urlDirName with the actual __dirname value when executing the script node. This ensures that the correct directory path is used for resolving any relative imports or file references within the script. |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2heal1
changed the title
| @@ -108,7 +108,7 @@ export function createScriptNode( | |||
| scriptContext.exports, | |||
| scriptContext.module, | |||
| eval('require'), | |||
| urlDirname, | |||
| __dirname, | |||
There was a problem hiding this comment.
this will be dirname of your current directory of evaluation, is that okay?
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
39bfbb444516cec371636e59b9d262b35a603d50...1980dfa4242cd448dbfba5ef737cf0634471d214
Files Reviewed
- packages/sdk/src/node.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/serious-actors-run.md
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
39bfbb444516cec371636e59b9d262b35a603d50...f5634c3131828eaf42824852379936cd56e0245a
Files Reviewed
- packages/sdk/src/node.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- .changeset/serious-actors-run.md
Description
pass real dirName instead of urlDirName
Related Issue
Types of changes
Checklist