fix(runtime): prefer using globalThis directly #3108
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting a reference to the global this, the current code tries to run
new Function('return this')()
which is blocked by most CSPs. While the fallback code in thecatch
runs fine so there's no runtime error, the CSP violations still might get reported which pollutes the tracking data.This PR changes the logic so it prefers returning
globalThis
directly, similarly to the webpack runtime:core/packages/webpack-bundler-runtime/src/container.ts
Lines 199 to 206 in 3ac3fc8
Related Issue
Fixes #3103
Types of changes
Checklist