Move retract to directly after the blob. #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the final retract to the end of the blob, before the z-lift. Cuts the blob off cleanly, instead of leaving a string on it. This means the blobs separate cleanly in the bucket instead of all tangling together.
|
Makes sense to me. @Dendrowen ok with you? (I'm trying to change blobifier without your thumbs up) |
|
Yes, looks good to me! |
|
Nice! I've done quite a bit more testing, it seems to work as I expected it to, which is great 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the final retract to the end of the blob, before the z-lift. Cuts the blob off cleanly, instead of leaving a string on it. This means the blobs separate cleanly in the bucket instead of all tangling together.
My initial testing shows this works better.
I will do some more testing on this and see how it goes, but also released here so others can review it. Overall it makes sense to me to do it this way.