Fixes thread safety issues in android code. closes #161 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, every call from flutter was executed in a separate thread and only the ensureInitStorageCipher was synchronized. All other operations were run without any synchronization. Most of the code is not thread safe, which caused multiple problems when two or more method calls happened to run at the same time. This commit fixes the thread safety issues by using a single worker thread in which all calls from flutter are executed.
mogol
reviewed
Oct 8, 2020
android/src/main/java/com/it_nomads/fluttersecurestorage/FlutterSecureStoragePlugin.java
Show resolved
Hide resolved
|
@koskimas thanks |
|
@mogol Thank you for reviewing and merging this so quickly! And thanks again for your work on this library. |
|
I really hope it resolves this long running issues, as it was completely mystery for me for a while 🙏 really appreciate your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, every call from flutter was executed in a separate thread and only the ensureInitStorageCipher was synchronized. All other operations were run without any synchronization. Most of the code is not thread safe, which caused multiple problems when two or more method calls happened to run at the same time.
This PR fixes the thread safety issues by using a single worker thread in which all calls from flutter are executed.
This closes #161 but probably also fixes #163.