Initial scrollview support #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olling to finish before measuring
|
Thanks, @dancalifornia. @mohebifar, can you take a look at this at some point? :) |
|
@mohebifar Ping. :) |
|
Hi @dancalifornia, thanks for the PR! Can you please share a snack example and add a short instruction to the README on how to use this feature? |
|
any solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional scrollview support.
If a scrollview ref is provided, I set a slight timeout before measuring the next step. There is no callback / event that I am aware of on scrollTo finish for me to call moveToCurrentStep.