Skip to content

Commit

Permalink
fix: item wise tax detail missing on shipping lines (frappe#232)
Browse files Browse the repository at this point in the history
caused by frappe#229

```
Traceback (most recent call last):
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/order.py", line 49, in sync_sales_order
    create_order(order, setting)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/order.py", line 61, in create_order
    so = create_sales_order(order, setting, company)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/order.py", line 96, in create_sales_order
    taxes = get_order_taxes(shopify_order, setting, items)
  File "apps/ecommerce_integrations/ecommerce_integrations/shopify/order.py", line 223, in get_order_taxes
    row["item_wise_tax_detail"] = json.dumps(row["item_wise_tax_detail"])
KeyError: 'item_wise_tax_detail'
```
  • Loading branch information
ankush authored Feb 16, 2023
1 parent f158a4a commit 08e41d2
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ecommerce_integrations/shopify/order.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ def get_order_taxes(shopify_order, setting, items):
taxes = consolidate_order_taxes(taxes)

for row in taxes:
row["item_wise_tax_detail"] = json.dumps(row["item_wise_tax_detail"])
tax_detail = row.get("item_wise_tax_detail")
if isinstance(tax_detail, dict):
row["item_wise_tax_detail"] = json.dumps(tax_detail)

return taxes

Expand Down

0 comments on commit 08e41d2

Please sign in to comment.