Skip to content

Commit

Permalink
feat: Added specific metric for graphite unavailability check result
Browse files Browse the repository at this point in the history
  • Loading branch information
d.anchikov committed Jul 6, 2022
1 parent 88feba3 commit 2d00284
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
1 change: 1 addition & 0 deletions checker/worker/remote.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func (worker *Checker) checkRemote() error {
remoteAvailable, err := source.(*remote.Remote).IsRemoteAvailable()
if !remoteAvailable {
worker.Logger.Infof("Remote API is unavailable. Stop checking remote triggers. Error: %s", err.Error())
worker.Metrics.RemoteAvailabilityCheckFailed.Mark(1)
} else {
worker.Logger.Debug("Checking remote triggers")
triggerIds, err := worker.Database.GetRemoteTriggerIDs()
Expand Down
12 changes: 7 additions & 5 deletions metrics/checker.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ import "github.com/moira-alert/moira"

// CheckerMetrics is a collection of metrics used in checker
type CheckerMetrics struct {
LocalMetrics *CheckMetrics
RemoteMetrics *CheckMetrics
MetricEventsChannelLen Histogram
UnusedTriggersCount Histogram
MetricEventsHandleTime Timer
LocalMetrics *CheckMetrics
RemoteMetrics *CheckMetrics
MetricEventsChannelLen Histogram
UnusedTriggersCount Histogram
MetricEventsHandleTime Timer
RemoteAvailabilityCheckFailed Meter
}

// GetCheckMetrics return check metrics dependent on given trigger type
Expand Down Expand Up @@ -37,6 +38,7 @@ func ConfigureCheckerMetrics(registry Registry, remoteEnabled bool) *CheckerMetr
}
if remoteEnabled {
m.RemoteMetrics = configureCheckMetrics(registry, "remote")
m.RemoteAvailabilityCheckFailed = registry.NewMeter("remote", "unavailable")
}
return m
}
Expand Down

0 comments on commit 2d00284

Please sign in to comment.