Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/2886): fixed bulkQuotes response in sdk-out api #137

Merged
merged 4 commits into from
Aug 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,189 changes: 593 additions & 596 deletions docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml

Large diffs are not rendered by default.

369 changes: 204 additions & 165 deletions package-lock.json

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@
"@commitlint/cli": "^17.0.3",
"@commitlint/config-conventional": "^17.0.3",
"@redocly/openapi-cli": "^1.0.0-beta.94",
"@types/jest": "^28.1.6",
"@typescript-eslint/eslint-plugin": "^5.31.0",
"@typescript-eslint/parser": "^5.31.0",
"@types/jest": "^28.1.7",
"@typescript-eslint/eslint-plugin": "^5.34.0",
"@typescript-eslint/parser": "^5.34.0",
"diff": "^5.1.0",
"eslint": "^8.20.0",
"eslint": "^8.22.0",
"eslint-config-prettier": "^8.5.0",
"eslint-config-standard": "^17.0.0",
"eslint-import-resolver-typescript": "^3.3.0",
"eslint-import-resolver-typescript": "^3.5.0",
"eslint-plugin-cucumber": "^2.0.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-node": "^11.1.0",
Expand All @@ -96,11 +96,11 @@
"jest-junit": "^14.0.0",
"lint-staged": "^13.0.3",
"npm-audit-resolver": "^3.0.0-7",
"npm-check-updates": "^16.0.1",
"npm-check-updates": "^16.0.5",
"prettier": "^2.7.1",
"standard-version": "^9.5.0",
"swagger-cli": "^4.0.4",
"ts-jest": "^28.0.7",
"ts-jest": "^28.0.8",
"ts-node": "^10.9.1",
"tslib": "^2.4.0",
"typescript": "^4.7.4"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
type: object
required:
- from
- bulkQuoteId
- individualQuoteResults
properties:
quoteId:
bulkQuoteId:
$ref: ./CorrelationId.yaml
homeTransactionId:
type: string
description: >-
Transaction ID from the DFSP backend, used to reconcile transactions
between the Switch and DFSP backend systems.
from:
$ref: ./transferParty.yaml
expiration:
$ref: ./DateTime.yaml
extensionList:
$ref: ./ExtensionList.yaml
individualQuoteResults:
type: array
maxItems: 1000
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,23 @@
type: object
required:
- from
- bulkTransferId
- individualTransferResults
properties:
transferId:
bulkTransferId:
$ref: ./CorrelationId.yaml
from:
$ref: ./transferParty.yaml
bulkQuoteId:
$ref: ./CorrelationId.yaml
homeTransactionId:
type: string
description: >-
Transaction ID from the DFSP backend, used to reconcile transactions
between the Switch and DFSP backend systems.
bulkTransferState:
$ref: ./TransferState.yaml
completedTimestamp:
$ref: ./DateTime.yaml
extensionList:
$ref: ./ExtensionList.yaml
individualTransferResults:
type: array
maxItems: 1000
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,33 @@ type: object
properties:
quoteId:
$ref: ./CorrelationId.yaml
to:
$ref: ./transferParty.yaml
amountType:
$ref: ./AmountType.yaml
currency:
$ref: ./Currency.yaml
amount:
$ref: ./Amount.yaml
transactionType:
$ref: ./transferTransactionType.yaml
note:
$ref: ./Note.yaml
transferAmount:
$ref: ./Money.yaml
payeeReceiveAmount:
$ref: ./Money.yaml
payeeFspFee:
$ref: ./Money.yaml
payeeFspCommission:
$ref: ./Money.yaml
geoCode:
$ref: ./GeoCode.yaml
ilpPacket:
$ref: ./IlpPacket.yaml
condition:
$ref: ./IlpCondition.yaml
extensionList:
$ref: ./ExtensionList.yaml
description: 'Optional extension, specific to deployment.'
lastError:
description: >
Object representing the last error to occur during a quote process. This
may be a Mojaloop API error returned from another entity in the scheme or
an object representing other types of error e.g. exceptions that may occur
inside the scheme adapter.
$ref: ./quoteError.yaml

required:
- transferAmount
- expiration
- ilpPacket
- condition
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ properties:
amount:
$ref: ./Amount.yaml
transactionType:
$ref: ./TransactionType.yaml
$ref: ./transferTransactionType.yaml
note:
$ref: ./Note.yaml
extensions:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,37 +1,16 @@
type: object
required:
- transactionId
- to
- amountType
- currency
- amount
- transferId
properties:
transferId:
$ref: ./CorrelationId.yaml
to:
$ref: ./transferParty.yaml
amountType:
$ref: ./AmountType.yaml
currency:
$ref: ./Currency.yaml
amount:
$ref: ./Amount.yaml
transactionType:
$ref: ./transferTransactionType.yaml
note:
$ref: ./Note.yaml
quoteId:
$ref: ./CorrelationId.yaml
quoteResponse:
$ref: ./QuotesIDPutResponse.yaml
quoteResponseSource:
type: string
fulfilment:
$ref: ./IlpFulfilment.yaml
description: >
FSPID of the entity that supplied the quote response. This may not
be the same as the FSPID of the entity which owns the end user
account in the case of a FOREX transfer. i.e. it may be a FOREX
gateway.
fulfil:
$ref: ./TransfersIDPutResponse.yaml
Fulfilment of the condition specified with the transaction.
Mandatory if transfer has completed successfully.
extensionList:
$ref: ./ExtensionList.yaml
description: 'Optional extension, specific to deployment.'
lastError:
$ref: ./transferError.yaml
Loading