Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mojaloop/3345): enhance payee requesttopay apis #162

Merged
merged 8 commits into from
May 19, 2023
Merged

feat(mojaloop/3345): enhance payee requesttopay apis #162

merged 8 commits into from
May 19, 2023

Conversation

vijayg10
Copy link
Contributor

@vijayg10 vijayg10 commented May 18, 2023 •
edited
Loading

feat(mojaloop/3345): enhance payee requesttopay apis

Changes:

  • SDK Outbound API
    • Added PUT /requestToPay endpoint in SDK Outbound API in api-snippets
    • Renamed homeTransactionId to homeR2PTransactionId in POST /requestToPay
    • Added Authentication type to POST \requestToPay to SDK Outbound
    • Renamed requestToPayState to currentState in requestToPayResponse
    • Added getPartiesResponse in requestToPayResponse
    • Added transactionRequestResponse in requestToPayResponse
    • Removed authenticationType in requestToPayResponse
  • SDK Backend API
    • Added authentication type to POST \transactionRequest
    • Renamed the TransferAmount to TransactionRequestState
    • Added homeR2PTransactionId to POST \transactionRequest sync response

@vijayg10 vijayg10 self-assigned this May 18, 2023
@vijayg10 vijayg10 mentioned this pull request May 18, 2023
Closed
45 tasks
mdebarros
mdebarros reviewed May 18, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments...

sdk-scheme-adapter/v2_0_0/backend/openapi.yaml Show resolved Hide resolved
sdk-scheme-adapter/v2_0_0/backend/openapi.yaml Show resolved Hide resolved
sdk-scheme-adapter/v2_0_0/backend/openapi.yaml Show resolved Hide resolved
sdk-scheme-adapter/v2_0_0/components/parameters/transactionRequestId.yaml Show resolved Hide resolved
sdk-scheme-adapter/v2_0_0/components/schemas/requestToPayStatus.yaml Show resolved Hide resolved
@vijayg10 vijayg10 mentioned this pull request May 18, 2023
Closed
@vijayg10 vijayg10 requested a review from mdebarros May 19, 2023 09:27
mdebarros
mdebarros previously approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mdebarros
mdebarros approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vijayg10 vijayg10 merged commit 49b31e0 into master May 19, 2023
@vijayg10 vijayg10 deleted the feat/3345-enhance-payee-requesttopay branch May 19, 2023 14:47
@vijayg10 vijayg10 mentioned this pull request Jun 6, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@kleyow kleyow Awaiting requested review from kleyow

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@kirgene kirgene Awaiting requested review from kirgene

Assignees

@vijayg10 vijayg10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vijayg10 @mdebarros