Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Scheme Adapter is not accepting PUT /parties with 1.1 content-type header #1891

Closed
Tracked by #2151
vijayg10 opened this issue Dec 4, 2020 · 5 comments
Closed
Tracked by #2151

SDK Scheme Adapter is not accepting PUT /parties with 1.1 content-type header #1891

vijayg10 opened this issue Dec 4, 2020 · 5 comments
Assignees
@mdebarros
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it test-bug This is a bug in tests or test automation framework, not a code or functionality issue
Milestone
Sprint 14.3

Comments

@vijayg10
Copy link

vijayg10 commented Dec 4, 2020 •
edited
Loading

Summary:
SDK Scheme Adapter is not accepting PUT /parties with 1.1 content-type header
But post /quotes and post /transfers are working fine with 1.1 headers

Severity:
(Low, Medium, High)

Priority:
(Critical, Medium, Low)

Expected Behavior
SDK should accept get /parties with content-type header 1.1.

Steps to Reproduce

  1. Send a PUT request with content-type header "application/vnd.interoperability.parties+json;version=1.1"
  2. We will get 400 http error code with following body 
     {
     "errorInformation": {
         "errorCode": "3102",
         "errorDescription": "undefined must have required property 'body'"
     }
 }
  3. Send a PUT request with content-type header "application/vnd.interoperability.parties+json;version=1.0"
  4. We will get 200

Specifications

  • Component (if known): sdk-scheme-adapter
  • Version:
  • Platform:
  • Subsystem:
  • Type of testing:
  • Bug found/raised by: @vijayg10

Notes:

  • Severity when opened:
  • Priority when opened:
@vijayg10 vijayg10 added bug oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Dec 4, 2020
@vijayg10 vijayg10 changed the title SDK Scheme Adapter is not accepting get /parties with 1.1 accept header SDK Scheme Adapter is not accepting get /parties with 1.1 content-type header Dec 4, 2020
@vijayg10 vijayg10 changed the title SDK Scheme Adapter is not accepting get /parties with 1.1 content-type header SDK Scheme Adapter is not accepting PUT /parties with 1.1 content-type header Dec 4, 2020
@elnyry-sam-k elnyry-sam-k added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Feb 26, 2021
@elnyry-sam-k
Copy link
Member

@vijayg10 , @shashi165 - can you please confirm if this is still relevant / active?

@vijayg10
Copy link
Author

vijayg10 commented Jun 4, 2021 •
edited
Loading

@elnyry-sam-k I checked it just now with master branch, issue still exists

@elnyry-sam-k
Copy link
Member

Thanks Vijay

@elnyry-sam-k elnyry-sam-k added the to-be-refined This story is ready to be groomed label Jun 4, 2021
mdebarros added a commit to mdebarros/sdk-scheme-adapter that referenced this issue Jun 9, 2021
@mdebarros
Added fix for mojaloop/project#1891
039c06d
@mdebarros mdebarros mentioned this issue Jun 9, 2021
Merged
@mdebarros mdebarros self-assigned this Jun 9, 2021
This was referenced Jun 9, 2021
Closed
Closed
@mdebarros
Copy link
Member

mdebarros commented Jun 9, 2021 •
edited
Loading

This has been fixed on #275 PR - mojaloop/sdk-scheme-adapter@039c06d

This will be included in Helm v12.1.0 release.

There is a follow up story that I created based on my analysis of the SDK Adapter's current functionality: #2264

Specifically that the Adapter DOES NOT correctly validate the incoming content-type header, and does not match the correct "media-type" to the FSPIOP operation.

@elnyry-sam-k elnyry-sam-k added this to the Sprint 14.3 milestone Jun 9, 2021
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 9, 2021
@mdebarros
Merge pull request #275 from mdebarros/feature/#2151-helm-release-v12…
40e3cfc 
….1.0

feat(2151): helm-release-v12.1.0
- Updated dependencies
- Fixes for updated dependencies
- Bump patch version
- Fixed lint issues
- Added dep:check/update scripts, and made update:check/update aliases
- Fixed unit & integration tests - some refactoring required as using "async-await" & "done-callbacks" are not compatible --> jestjs/jest#10529
- Added fix for 'SDK Scheme Adapter is not accepting PUT /parties with 1.1 content-type header': mojaloop/project#1891
@elnyry-sam-k elnyry-sam-k added test-bug This is a bug in tests or test automation framework, not a code or functionality issue and removed to-be-refined This story is ready to be groomed labels Jun 14, 2021
@mdebarros mdebarros mentioned this issue Jun 28, 2021
Merged
@elnyry-sam-k
Copy link
Member

Fixed with https://github.com/mojaloop/helm/releases/tag/v13.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it test-bug This is a bug in tests or test automation framework, not a code or functionality issue
Projects
None yet
Milestone
Sprint 14.3
Development

No branches or pull requests
4 participants
@elnyry-sam-k @mdebarros @vijayg10 @godfreykutumela