Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parent level configurable for reference value in requirePropertyDiverges #295

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Make parent level configurable for reference value in requirePropertyDiverges #295

merged 3 commits into from
Mar 19, 2024

Conversation

piercemar
Copy link
Contributor

Enhancement proposal for rule requirePropertyDiverges

As proposed in #282 to @slawekjaranowski

Adds a new, optional <reference> parameter which can take 3 values:

  • DEFINING (current behaviour, default)
  • PARENT use direct parent as reference context
  • BASE use topmost local POM as reference context

Tests & doc included

@slawekjaranowski slawekjaranowski self-assigned this Mar 19, 2024
@slawekjaranowski slawekjaranowski linked an issue Mar 19, 2024 that may be closed by this pull request
RequirePropertyDiverges evaluates in own context #282
Closed
@slawekjaranowski slawekjaranowski merged commit 4d399e8 into mojohaus:master Mar 19, 2024
19 checks passed
@piercemar
Copy link
Contributor Author

Thanks for accepting the PR @slawekjaranowski. Looking forward for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees

@slawekjaranowski slawekjaranowski

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequirePropertyDiverges evaluates in own context
2 participants
@piercemar @slawekjaranowski