Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore automatically module-info.class when maxJdkVersion < 1.9 #76

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Ignore automatically module-info.class when maxJdkVersion < 1.9 #76

merged 1 commit into from
Mar 29, 2019

Conversation

Vlatombe
Copy link
Contributor

Context: #46, #36, #75

Fix from #36 would cause unnecessary noise such as

[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
[WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53

This supercedes #75.

This fix takes a different approach: when maxJdkVersion < 1.9, module-info is just ignored automatically.

batmat
batmat approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batmat batmat self-assigned this Mar 20, 2019
@batmat batmat requested a review from khmarbaise March 20, 2019 13:25
@batmat batmat merged commit d5bcf7e into mojohaus:master Mar 29, 2019
@batmat
Copy link
Member

batmat commented Apr 2, 2019

released as 1.2 in staging, vote in progress since a few minutes ago.

Will publish to Central in 72 hours w/o pushback.

@batmat
Copy link
Member

batmat commented Apr 2, 2019

https://groups.google.com/d/msg/mojohaus-dev/SiqIDHtDnuc/1RvKfpbYBwAJ

@Vlatombe
Copy link
Contributor Author

Vlatombe commented Apr 2, 2019

Cool, thanks @batmat

@Vlatombe Vlatombe deleted the ignore_module_info_before_jdk_9 branch April 2, 2019 11:37
@batmat batmat mentioned this pull request Apr 8, 2019
Merged
@slawekjaranowski slawekjaranowski mentioned this pull request Sep 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batmat batmat batmat approved these changes

@khmarbaise khmarbaise Awaiting requested review from khmarbaise

Assignees

@batmat batmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlatombe @batmat