Feature/extended interpolate #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't change line end and other whitespace |
SergeDemoulinGebit
added a commit
to GEBIT/flatten-maven-plugin
that referenced
this pull request
Mar 11, 2024
…ement from the interpolated POM, but resolve the variables with the properties from the effective POM. Don't resolve the following variables "project.basedir", "project.baseUri", "project.build.directory", "project.build.outputDirectory", "project.build.sourceDirectory", "project.build.scriptSourceDirectory", "project.build.testSourceDirectory", "project.reporting.outputDirectory" Interpolate the parent version optimization (only the used models are created)
SergeDemoulinGebit
force-pushed
the
feature/extended_interpolate
branch
from
60967eb
to
c36f8b3
Compare
SergeDemoulinGebit
force-pushed
the
feature/extended_interpolate
branch
from
c36f8b3
to
ba1be66
Compare
|
Hi I want to remove the dependency to guava. Please wait until I do that to make the review. Best regards, |
SergeDemoulinGebit
added a commit
to GEBIT/flatten-maven-plugin
that referenced
this pull request
Mar 12, 2024
SergeDemoulinGebit
force-pushed
the
feature/extended_interpolate
branch
from
ea2c835
to
4d75466
Compare
|
This would be huge for us because we have a lot of properties in a parent that need to be interpolated in lower POMs. |
|
Is there anything we can do to move this forward? |
This was
linked to
issues
May 8, 2024
|
I added myself to review, I will try to do it in a few days - @SergeDemoulinGebit thanks for PR |
|
right. I learnt it afterall |
slawekjaranowski
requested changes
May 14, 2024
|
The requested changes should be handled AFAICS. Anything else what should be done? |
|
Kind request -- can we move forward with this? |
slawekjaranowski
approved these changes
Sep 13, 2024
|
@SergeDemoulinGebit thanks |
|
Awesome, thank you so much! |
|
Thank you Slawomir 😄
…________________________________
From: Slawomir Jaranowski ***@***.***>
Sent: 13 September 2024 20:17
To: mojohaus/flatten-maven-plugin ***@***.***>
Cc: Serge Démoulin ***@***.***>; Mention ***@***.***>
Subject: Re: [mojohaus/flatten-maven-plugin] Feature/extended interpolate (PR #384)
@SergeDemoulinGebit<https://github.com/SergeDemoulinGebit> thanks
—
Reply to this email directly, view it on GitHub<#384 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BAILLUDEAHZWTZDFEPVQIM3ZWMT4TAVCNFSM6AAAAAA7U2QO5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZG43DIMBSGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new ElementHandling: "extended_interpolate"
Optimization (only the used models are created)