Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply only over active profiles #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

flabodotes
Copy link

When the property embedBuildProfileDependencies = true all the dependencies defined in the profiles are moved to project general dependencies. If you have the same dependency in several profiles but maybe with other versions after the flatten process the result contains duplicated definitions.

With the change proposed only the active profiles will be taken into account.

Gonzalez De Santos Felix and others added 2 commits April 6, 2017 16:03
@hohwille
Copy link
Member

Sorry, for the late response - I was totally under water with lots of other OSS and closed projects. Thanks for your PR. I see your point and agree that adding duplicated dependencies is to be considered as a bug.
However, the feature embedBuildProfileDependencies = true was introduced with a specific use-case in mind and is already used. Your PR will break the behavior of that feature in an incompatible manner. Therefore I can not accept your PR as is. We can discuss about introducing a new property to get the feature you are intending. However, this can easily result in different build-results depending on your environment what is actually an anti-goal for the initial idea of the project. Anyhow, I am not someone who wants to be a blocker of useful features for filling gaps in the maven ecosystem as I wrote this plugin exactly for the purpose of such gaps and because of my resulting frustration.
However, it would be very helpful if you could describe your use-case or intentions before we proceed. If it is just to avoid duplicate dependencies then we should file and fix an according bug (I will do that anyhow in the future, but I first want to verify this with an IT to get sure it really is as you tell).

@matthiasbalke
Copy link

@hohwille If this PR is breaking the API how about, increasing the major version and provide an upgrade tutorial?

@hohwille
Copy link
Member

If this PR is breaking the API how about, increasing the major version and provide an upgrade tutorial?

There are always different users with different use-cases and requirements. What seems like a natural thing for you to have as default is considered sick for others.
Can you still write a few lines to describe your use-case (what you have in your pom and what you would expect of flatten plugin to do for you what is currently not possible)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants